Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queue rate and only activate upon finality #1514

Merged
merged 11 commits into from
Dec 12, 2019
Merged

Fix queue rate and only activate upon finality #1514

merged 11 commits into from
Dec 12, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Dec 11, 2019 •
edited
Loading

addresses #1511 as well as a previously uncaught bug allowing for activations when no finality

  • ensures efficient processing of activation queue
  • ensures activations only happen at finality
  • adds a number of explicit tests for the activation queue
  • enhances process_registry_updates testing in general

protolambda
protolambda reviewed Dec 11, 2019
View reviewed changes
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
specs/core/0_beacon-chain.md Show resolved Hide resolved
@djrtwo djrtwo mentioned this pull request Dec 12, 2019
Closed
@djrtwo djrtwo changed the title [WIP] Fix queue rate and only activate upon finality Fix queue rate and only activate upon finality Dec 12, 2019
protolambda
protolambda reviewed Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see this part of the spec be clear about the relation to finalization, and nice work on tests for this 👍

hwwhww
hwwhww reviewed Dec 12, 2019
View reviewed changes
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
specs/core/0_beacon-chain.md Show resolved Hide resolved
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
specs/core/0_beacon-chain.md Show resolved Hide resolved
@shayzluf
Copy link

thanks @djrtwo assuring finality in activation makes slashing simpler

@djrtwo djrtwo merged commit 52a6cf7 into v09x Dec 12, 2019
@djrtwo djrtwo deleted the queue-fix-on-finality branch December 12, 2019 14:46
@djrtwo djrtwo mentioned this pull request Dec 12, 2019
Closed
@terencechain terencechain mentioned this pull request Dec 12, 2019
Closed
11 tasks
@terencechain terencechain mentioned this pull request Dec 26, 2019
Merged
@ChihChengLiang ChihChengLiang mentioned this pull request Jan 20, 2020
Merged
2 tasks
@wemeetagain wemeetagain mentioned this pull request Jan 21, 2020
Closed
11 tasks
@wemeetagain wemeetagain mentioned this pull request Feb 2, 2020
Merged
@ColinSchwarz ColinSchwarz mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda left review comments

@hwwhww hwwhww hwwhww left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djrtwo @shayzluf @hwwhww @protolambda