Add functions for deriving light client data #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `create_light_client_bootstrap` and `create_light_client_update` functions as a reference implementation for serving light client data. This also enables a new test harness to verify that light client data gets applied to a `LightClientStore` as expected.
|
This may also progress #2842 |
|
🤩 |
hwwhww
reviewed
Jul 15, 2022
tests/core/pyspec/eth2spec/test/altair/sync_protocol/test_light_client_sync.py
Outdated
Show resolved
Hide resolved
|
|
||
| ```yaml | ||
| { | ||
| update: string -- name of the `*.ssz_snappy` file to load |
There was a problem hiding this comment.
suggest adding a note about the suffix rules
There was a problem hiding this comment.
So far, the suffixes are just an implementation detail to avoid name clashes, the test runner does not need to know about their meaning, i.e., they can just take the filename from here and run the test without further processing the name.
tests/core/pyspec/eth2spec/test/altair/sync_protocol/test_light_client_sync.py
Outdated
Show resolved
Hide resolved
|
|
||
| def emit_slot(test, spec, state): | ||
| current_slot = state.slot | ||
| yield from [] |
There was a problem hiding this comment.
we can just
- remove this line and
- remove
yield fromfrom everyemit_slotcall
There was a problem hiding this comment.
Yeah, that is possible, but allowing the consistent yield from notion (even if not technically necessary) make the functions that append to the test script (setup_test, emit_slot, emit_update, finish_test) similar in use, which helps with readability of the usage code.
tests/core/pyspec/eth2spec/test/altair/sync_protocol/test_light_client_sync.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jul 15, 2022
The EF test format for the LC sync protocol is modified to verify checks after each step: ethereum/consensus-specs#2938 - The test runner is updated accordingly.
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
hwwhww
approved these changes
Jul 19, 2022
Comment on lines
+187
to
+188
| elif out_kind == "cfg": | ||
| output_part(out_kind, name, dump_yaml_fn(data, name, file_mode, cfg_yaml)) |
There was a problem hiding this comment.
Note for other reviewers:
- If the test case uses
with_config_overrides, it will outputconfig.yamlfile with this new file format. The new format is closer to the config files (mainnet.yaml&minimal.yaml). 👍 - It outputs more than the
*_FORK_EPOCHoverridden. For Bellatrix tests:
PRESET_BASE: 'minimal'
MIN_GENESIS_ACTIVE_VALIDATOR_COUNT: 64
MIN_GENESIS_TIME: 1578009600
GENESIS_FORK_VERSION: 0x00000001
GENESIS_DELAY: 300
SECONDS_PER_SLOT: 6
SECONDS_PER_ETH1_BLOCK: 14
MIN_VALIDATOR_WITHDRAWABILITY_DELAY: 256
SHARD_COMMITTEE_PERIOD: 64
ETH1_FOLLOW_DISTANCE: 16
EJECTION_BALANCE: 16000000000
MIN_PER_EPOCH_CHURN_LIMIT: 4
CHURN_LIMIT_QUOTIENT: 32
PROPOSER_SCORE_BOOST: 40
INACTIVITY_SCORE_BIAS: 4
INACTIVITY_SCORE_RECOVERY_RATE: 16
ALTAIR_FORK_VERSION: 0x01000001
ALTAIR_FORK_EPOCH: 0
TERMINAL_TOTAL_DIFFICULTY: 115792089237316195423570985008687907853269984665640564039457584007913129638912
TERMINAL_BLOCK_HASH: 0x0000000000000000000000000000000000000000000000000000000000000000
TERMINAL_BLOCK_HASH_ACTIVATION_EPOCH: 18446744073709551615
BELLATRIX_FORK_VERSION: 0x02000001
BELLATRIX_FORK_EPOCH: 0- p.s. deposit contract configurations are not included because
deposit-contract.mdis not part of executable pyspec.
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jul 23, 2022
The EF test format for the LC sync protocol is modified to verify checks after each step: ethereum/consensus-specs#2938 - The test runner is updated accordingly.
29 tasks
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
create_light_client_bootstrapandcreate_light_client_updatefunctions as a reference implementation for serving light client data.
This also enables a new test harness to verify that light client data
gets applied to a
LightClientStoreas expected.