Clarify merkle_root documentation #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is used to get the merkle root of some block roots which are themselves hashes, so the leaves do not need to be rehashed. Unfortunately, it's easy to assume that a merkle_root function would hash its leaves, so it should be clarified.
JustinDrake
approved these changes
Feb 17, 2019
wemeetagain
added a commit
to wemeetagain/prysm
that referenced
this pull request
Feb 19, 2019
See ethereum/consensus-specs#646 for clarification.
wemeetagain
added a commit
to wemeetagain/prysm
that referenced
this pull request
Feb 19, 2019
See ethereum/consensus-specs#646 for clarification.
wemeetagain
added a commit
to wemeetagain/prysm
that referenced
this pull request
Feb 19, 2019
See ethereum/consensus-specs#646 for clarification.
nisdas
pushed a commit
to prysmaticlabs/prysm
that referenced
this pull request
Feb 20, 2019
* Remove leaf hashing in MerkleRoot function See ethereum/consensus-specs#646 for clarification. * Add comment clarifying leaf hashing removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is used to get the merkle root of some block roots which are themselves hashes, so the leaves do not need to be rehashed.
Unfortunately, it's easy to assume that a merkle_root function would hash its leaves, so it should be clarified somehow.