Decouple justification and finalization processing #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More readable and saves a few lines.
vbuterin
approved these changes
Apr 15, 2019
hwwhww
reviewed
Apr 16, 2019
hwwhww
approved these changes
Apr 16, 2019
I guess |
Merged
djrtwo
reviewed
Apr 17, 2019
| state.finalized_epoch = antepenultimate_justified_epoch | ||
| state.finalized_root = get_block_root(state, get_epoch_start_slot(state.finalized_epoch)) | ||
| # The 1st/2nd/3rd most recent epochs are justified, the 1st using the 3rd as source | ||
| if (bitfield >> 0) % 8 == 0b111 and state.previous_justified_root == current_epoch - 2: |
There was a problem hiding this comment.
This is a bug. making new PR
|
I'm pretty sure we used to do it in a similar way but this was seen as difficult to analyze because we were changing things around in the state before running the comparisons.. For example parsing what |
Merged
JustinDrake
added a commit
that referenced
this pull request
Apr 18, 2019
Addresses @djrtwo's comment [here](#925 (comment)).
JustinDrake
added a commit
that referenced
this pull request
Apr 18, 2019
Addresses @djrtwo's comment [here](#925 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More readable and saves a few lines.