This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Giving out snapshot through Warp protocol #4710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
snapshot-server
branch
from
a9b66c8 to
93fa294
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4710 +/- ##
===========================================
+ Coverage 59.51% 60.79% +1.28%
===========================================
Files 342 347 +5
Lines 27026 27298 +272
Branches 2838 2865 +27
===========================================
+ Hits 16084 16597 +513
+ Misses 9981 9705 -276
- Partials 961 996 +35 |
|
Applied clang-format in the separate commit |
added 3 commits
December 19, 2017 17:13
gumb0
force-pushed
the
snapshot-server
branch
from
e804a24 to
1574135
Compare
… produces too many messages from BlockHeader class during blocks import
pirapira
reviewed
Dec 21, 2017
libethereum/WarpPeerCapability.cpp
Outdated
| auto const networkId = _r[1].toInt<u256>(RLP::VeryStrict); | ||
| auto const totalDifficulty = _r[2].toInt<u256>(RLP::VeryStrict); | ||
| auto const latestHash = _r[3].toHash<h256>(RLP::VeryStrict); | ||
| auto const genesisHash = _r[4].toHash<h256>(RLP::VeryStrict); |
There was a problem hiding this comment.
Is it a good idea to check genesisHash against _chainGenesisHash given to init()? (Likewise for networkId?)
There was a problem hiding this comment.
Yes, I do that in the snapshot downloading PRs.
In this PR it doesn't make much difference, because it's a server part, and downloading peer checks it anyway.
I will add it later, anyway
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot files won't ever change and the node will give out the same snapshot all the time.
Further improvements could support periodic generation of our own snapshots.