Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: TableOfContents #4721

Closed
Hakeemmidan opened this issue Dec 10, 2021 · 3 comments · Fixed by #4722
Closed

Redesign: TableOfContents #4721

Hakeemmidan opened this issue Dec 10, 2021 · 3 comments · Fixed by #4722
Labels
feature ✨ This is enhancing something existing or creating something new

Comments

@Hakeemmidan
Copy link
Contributor

Hakeemmidan commented Dec 10, 2021

Is your feature request related to a problem? Please describe.

Not really. Just a redesign of TableOfContents component contents.

Describe the solution you'd like

From

Inactive active
Screen Shot 2021-12-10 at 11 07 54 PM Screen Shot 2021-12-10 at 11 11 15 PM

To

Inactive active
Screen Shot 2021-12-10 at 11 07 20 PM Screen Shot 2021-12-10 at 11 07 33 PM

Things that changed:

  • 'Edit page' button and 'zen mode' toggle are moved to the bottom of the component
    • Why?
      • Because the table of content information should be more prominent than 'zen mode' and 'edit page', as it is the main purpose of the TabeleOfContents component
  • Removed text and toggle of zen mode and replaced with a toggleable icon, and lowered its opacity (to make it less distracting).
  • Lowered opacity of the 'edit page' (to make it less distracting).

Describe alternatives you've considered
#4168

Additional context

  • I used the FaYinYang react icon for the zen mode toggle. I feel like there might be better fitting icons. Let me know if you know of any that might be a better fit! = )
  • Edit: I also unintentionally created the full-redesign/branch needed for the PR while making the mock-up for this issue so I pushed that as well and connected it to this issue (Design: Redesign TableOfContents #4722)
@Hakeemmidan Hakeemmidan added the feature ✨ This is enhancing something existing or creating something new label Dec 10, 2021
@victorlrz
Copy link

@Hakeemmidan I would love to work on this :)

@Hakeemmidan
Copy link
Contributor Author

@victorlrz
There's a pull request for this already, unfortunately.
Thank you for the enthusiasm though! = )

PS: This seems like a similar issue (design/frontend related), and it's marked as 'stale', so it might be a good candidate to check out! ( ^___^ )

@victorlrz
Copy link

Oh thanks @Hakeemmidan :) I'll have a loook !

Hakeemmidan added a commit to Hakeemmidan/ethereum-org-website that referenced this issue Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ This is enhancing something existing or creating something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants