test(fw): Unit tests for post state verification errors #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
previously requested changes
Dec 1, 2023
danceratopz
added
type:test
spencer-tb
changed the title
6 tasks
danceratopz
reviewed
Jan 18, 2024
There was a problem hiding this comment.
A couple of things occurred to me whilst working on #380, see comments below.
spencer-tb
force-pushed
the
unit_tests
branch
from
299dabe
to
0cf36cd
Compare
|
I tried to express the test's intent a bit better by removing the split of exception checking across the helper function and the test. Now we have the setup code in the |
* refactor: use pytest fixtures as apposed to helper function * refactor: update comments due to state test fixtures #356 The functionality from ethereum_test.filler.fill_test() got moved to the StateTest, respectively BlockchainTest, generate() method.
spencer-tb
force-pushed
the
unit_tests
branch
from
0a22c6b
to
b42b4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds filling framework unit tests for post state verification, of accounts including storage, nonce, code & balance mismatch. Ensure that the framework post state mismatches are occuring correctly.
🔗 Related Issues
N/A.
✅ Checklist