refactor(fw): make exception classes kw_only dataclasses to improve testability
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main aim of this change is to make it easier to test the exception classes defined in `ethereum_test_tools.common.types` as dataclasses automatically get a `__eq__()` method. Applying `kw_only` should help with readability.
danceratopz
added
type:refactor
danceratopz
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Jan 18, 2024
danceratopz
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR makes the custom exception classes defined in
ethereum_test_tools.common.typesaskw_onlydataclasses.The primary aim is to make it easier to test these exception classes; dataclasses automatically get a
__eq__()method which can be used for comparison in tests. Applyingkw_onlyalso helps readability.🔗 Related Issues
Should help improve PR #350 (respectively #380).
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.