Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix deprecated vs code settings #344 #420

Merged

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Jan 31, 2024

🗒️ Description

Removes deprecated settings from our recommended VS Code settings and adds the microsoft mypy extension. This change is necessary since (from the log):

Linting features have been moved to separate linter extensions.

More info: https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions

🔗 Related Issues

Fixes #344.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added the type:chore Type: Chore label Jan 31, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@spencer-tb spencer-tb merged commit 77f887a into ethereum:main Jan 31, 2024
5 checks passed
spencer-tb pushed a commit to spencer-tb/execution-spec-tests that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Fix vscode settings and add new recommended extensions
2 participants