Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fw): pypy compatibility - replace bytes=self with just self. #451

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented Feb 22, 2024

πŸ—’οΈ Description

pypy doesn't name this parameter for some reason.

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

pypy doesn't name this parameter for some reason.
@marioevz marioevz added type:bug Something isn't working scope:fw Scope: Framework (evm|tools|forks|pytest) labels Feb 22, 2024
@marioevz marioevz changed the title pypy compatibility replace bytes=self with just self. fix(fw): pypy compatibility - replace bytes=self with just self. Feb 22, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marioevz marioevz merged commit bf35d79 into ethereum:main Feb 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants