Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fw): Add with_all_contract_creating_tx_types marker #602

Merged
merged 11 commits into from
Jun 7, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 6, 2024

🗒️ Description

  • Makes the transaction class more permissible to always allow the creation of a valid transaction with the minimum number of set fields (in order to more easily parameterize the same test with multiple transaction types without having to worry about the specifics of each type).
  • Fix for evmone when passing a contract-creating tx: Use tx: "" instead of tx: null.
  • Add a contract_creating_tx_types to all forks to return all the supported transactions that can create contracts for the given fork.
  • Add a new covariant marker called with_all_contract_creating_tx_types to automatically parameterize a test with all the fork supported transaction types that can create a contract.

TODO: Check 1-to-1 fixture generation 1-to-1 fixture generation is verified.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels Jun 6, 2024
@marioevz marioevz requested a review from spencer-tb June 6, 2024 21:42
@marioevz marioevz changed the title Fixes for eof tx create feat(fw): Add with_all_contract_creating_tx_types marker Jun 6, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice addition! I commented a few small potenetial tweaks if you want to add them.

And also a comment about checking whether evmone could handle the empty string case on there end. My naive-ity might be underestimating C++ though

src/evm_transition_tool/evmone.py Outdated Show resolved Hide resolved
src/evm_transition_tool/transition_tool.py Outdated Show resolved Hide resolved
src/evm_transition_tool/transition_tool.py Outdated Show resolved Hide resolved
src/evm_transition_tool/transition_tool.py Show resolved Hide resolved
marioevz and others added 4 commits June 7, 2024 09:32
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
@marioevz marioevz merged commit ab46fff into ethereum:main Jun 7, 2024
5 checks passed
@marioevz marioevz deleted the fixes-for-eof-tx-create branch June 7, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants