-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fw): Add with_all_contract_creating_tx_types
marker
#602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
added
type:feat
type: Feature
scope:fw
Scope: Framework (evm|tools|forks|pytest)
labels
Jun 6, 2024
marioevz
changed the title
Fixes for eof tx create
feat(fw): Add Jun 6, 2024
with_all_contract_creating_tx_types
marker
spencer-tb
reviewed
Jun 7, 2024
spencer-tb
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice addition! I commented a few small potenetial tweaks if you want to add them.
And also a comment about checking whether evmone could handle the empty string case on there end. My naive-ity might be underestimating C++ though
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
spencer-tb
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
tx: ""
instead oftx: null
.contract_creating_tx_types
to all forks to return all the supported transactions that can create contracts for the given fork.with_all_contract_creating_tx_types
to automatically parameterize a test with all the fork supported transaction types that can create a contract.TODO: Check 1-to-1 fixture generation1-to-1 fixture generation is verified.🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.