Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit hash missing from Geth version in Docker builds #15346

Closed
karalabe opened this issue Oct 20, 2017 · 1 comment · Fixed by #15458
Closed

Commit hash missing from Geth version in Docker builds #15346

karalabe opened this issue Oct 20, 2017 · 1 comment · Fixed by #15458
Labels
good first issue help wanted

Comments

@karalabe
Copy link
Member

karalabe commented Oct 20, 2017 •
edited
Loading

In our Dockerfile, make geth does not inject the commit hash into Geth's version string because the .git repository is ignored via .dockerignore.

Would help to figure out which files from .git should be forwarded into the docker build process to re-enable the commit hashes in the version string. A good starter is build.LocalEnv, which tries to pull the commit hash from git.

You can also read the discussion in #15351 for the proposal of a good solution (the PR itself wasn't suitable).
@karalabe karalabe changed the title Commit hash missing from Docker builds Commit hash missing from Geth version in Docker builds Oct 20, 2017
@dpetzold dpetzold mentioned this issue Oct 20, 2017
Closed
@asasmoyo
Copy link
Contributor

Hello! I would like to start my contribution to Ethereum. If no one working on this, I would like to take it :)

@asasmoyo asasmoyo mentioned this issue Nov 11, 2017
Merged
asasmoyo added a commit to asasmoyo/go-ethereum that referenced this issue Nov 11, 2017
@asasmoyo
.dockerignore, internal/build: Read git information directly from file
8ea55cb 
This commit changes the way of retrieving git commit and branch for build
environment from running git command to reading git files directly.

This commit also adds required git files into Docker build context.

fixes: ethereum#15346
karalabe pushed a commit that referenced this issue Nov 12, 2017
@asasmoyo @karalabe
.dockerignore, internal/build: Read git information directly from file (
f47adc9 
#15458)

* .dockerignore, internal/build: Read git information directly from file

This commit changes the way of retrieving git commit and branch for build
environment from running git command to reading git files directly.

This commit also adds required git files into Docker build context.

fixes: #15346

* .dockerignore: workaround for including some files in .git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.dockerignore, internal/build: Read git information directly from file asasmoyo/go-ethereum
2 participants
@karalabe @asasmoyo