Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixhash not returned in the rpc #2508

Closed
wanderer opened this issue May 2, 2016 · 12 comments
Closed

mixhash not returned in the rpc #2508

wanderer opened this issue May 2, 2016 · 12 comments
Assignees
Milestone

Comments

@wanderer
Copy link
Member

@wanderer wanderer commented May 2, 2016

The mix hash is currently not returned in blocks in the RPC

@kumavis
Copy link
Member

@kumavis kumavis commented May 2, 2016

this is the only apart of the blockchain not available via RPC

@obscuren
Copy link
Member

@obscuren obscuren commented May 2, 2016

Yes, that's correct. The RPC spec doesn't define the mix hash to be included in the response.

I'm unsure of this issue and what your intentions are (we do have that template - that you deleted - for a reason, you know :-p). Are you looking to change the RPC spec, did you think we implemented it incorrectly or submit a feature request? :-)

@wanderer
Copy link
Member Author

@wanderer wanderer commented May 3, 2016

Are you looking to change the RPC spec, did you think we implemented it incorrectly or submit a feature request? :-)

Either works! Just as long as there is some way to get the mixhash :)

@fjl
Copy link
Contributor

@fjl fjl commented Jul 29, 2016

I need this too.

@fjl fjl self-assigned this Jul 29, 2016
@fjl fjl added this to the 1.5.0 milestone Jul 29, 2016
@fjl
Copy link
Contributor

@fjl fjl commented Aug 25, 2016

This has landed on develop as part of #2930

@wanderer
Copy link
Member Author

@wanderer wanderer commented Aug 25, 2016

yay thanks @fjl

@fjl
Copy link
Contributor

@fjl fjl commented Aug 25, 2016

All the details are here: b0d9f73

You should now be able to reconstruct all consensus-related objects from RPC output values.

@kumavis
Copy link
Member

@kumavis kumavis commented Oct 25, 2016

@fjl I think this can be closed now 👍

@fjl
Copy link
Contributor

@fjl fjl commented Oct 25, 2016

We will close it when geth 1.5 is released. The change is not in any release yet.

@kumavis
Copy link
Member

@kumavis kumavis commented Oct 25, 2016

oh woah! should be a pretty big changelog then : )
keep up the good work

@fjl
Copy link
Contributor

@fjl fjl commented Nov 15, 2016

Fix released in 1.5.0.

@fjl fjl closed this Nov 15, 2016
@kumavis
Copy link
Member

@kumavis kumavis commented Nov 15, 2016

yeeehaw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants