eth: fix error casting regression during database open #1963
+3
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zelig Please take a look at this PR that it still works as originally intended. |
Current coverage is
|
|
👍 |
eth/backend.go
Outdated
There was a problem hiding this comment.
This fix is nice and simple, so 👍. However, if you have the time, please make this a map[uint]bool instead.
Empty structs are nice but hurt readbility in this case.
There was a problem hiding this comment.
Sure thing, will fix in a moment.
|
👍 |
obscuren
added a commit
that referenced
this pull request
Nov 5, 2015
eth: fix error casting regression during database open
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced into the database opening where a return error was always interpreted as a
syscall.Errno, even though it can be a lot of different things. Permission error is one where it crashes, but there could be others too.