Skip to content

accounts/keystore: add timeout to test to prevent failure on travis #21703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2020
Merged

accounts/keystore: add timeout to test to prevent failure on travis #21703

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f55a9f4
accounts/keystore: add timeout to test to prevent failure on travis
MariusVanDerWijden Oct 13, 2020
c9c6b5c
accounts/keystore: added newlines back in
MariusVanDerWijden Oct 13, 2020
82b853d
accounts/keystore: properly fix the walletNotifications test
MariusVanDerWijden Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion accounts/keystore/keystore_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,9 @@ func TestWalletNotifications(t *testing.T) {

// Shut down the event collector and check events.
sub.Unsubscribe()
<-updates
for ev := range updates {
events = append(events, walletEvent{ev, ev.Wallet.Accounts()[0]})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey wait. Can't this be a nil deref in case the sub already Erred (and the ev is nil?)?
Guess we'll find out on travis, though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but I think range stops if the retrived ev is nil

}
checkAccounts(t, live, ks.Wallets())
checkEvents(t, wantEvents, events)
}
Expand Down