cleanup module imports #1394
cleanup module imports #1394
Conversation
|
@luclu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hiddentao, @frozeman and @ChihChengLiang to be potential reviewers. |
| require('../openExternal.js'); | ||
| require('./include/getFavicon.js'); | ||
| require('./include/getMetaTags.js'); | ||
| require('./include/openExternal.js'); |
There was a problem hiding this comment.
This is rather weird, not sure how this (https://github.com/ethereum/mist/commits/develop/modules/preloader/browser.js) happened. Very important to fix this ASAP!
| require('../openExternal.js'); | ||
| require('./include/getFavicon.js'); | ||
| require('./include/getMetaTags.js'); | ||
| require('./include/openExternal.js'); |
There was a problem hiding this comment.
It only happened on these two files as I compared all manually.
|
|
||
| const SocketBase = require('./base'), | ||
| Socket = SocketBase.Socket, | ||
| STATE = SocketBase.STATE; |
There was a problem hiding this comment.
Can these unused variables safely be removed?
There was a problem hiding this comment.
lets keep it for now, could be used from some other file?
There was a problem hiding this comment.
I readded it for now.
|
|
||
| const _ = global._; | ||
| const dechunker = require('../ipc/dechunker.js'); |
There was a problem hiding this comment.
Is this import of the dechunker needed?
There was a problem hiding this comment.
http should not use that, is it used anywhere?
There was a problem hiding this comment.
it's nowhere to be found within the interface dir
| const net = require('net'); | ||
|
|
||
| const _ = global._; | ||
| const dechunker = require('../ipc/dechunker.js'); |
There was a problem hiding this comment.
Yes can be removed from all BUT /modules/sockets/web3Base.js
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
No description provided.