Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compatible_p2p_version #89 #90

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Fixed compatible_p2p_version #89 #90

merged 1 commit into from
Feb 7, 2018

Conversation

hwwhww
Copy link

@hwwhww hwwhww commented Oct 24, 2017

Fixed #89：Version clash with devp2p v5 as defined by EIP706

  1. Since devp2p v5 is defined by EIP706, set the compatible_p2p_version
    to 5.
  2. Assuming that pyethapp doesn't compatible with above version, disconnect
    if the peer uses devp2p>v5.

@hwwhww
Fixed compatible_p2p_version
e12d5b8 
1. Since devp2p v5 is defined by EIP706, set the compatible_p2p_version
to 5
2. Assuming that pyethapp doesn't compatible with above version, disconnect
if the peer uses devp2p>v5
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 88.008% when pulling e12d5b8 on hwwhww:p2p_version_patch into 62db488 on ethereum:develop.

@ChihChengLiang ChihChengLiang mentioned this pull request Feb 2, 2018
Closed
@ChihChengLiang ChihChengLiang merged commit b09b8a0 into ethereum:develop Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwwhww @coveralls @ChihChengLiang