Skip to content

Use standard json internally in solcjs in every case #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

axic
Copy link
Member

@axic axic commented Oct 4, 2018

Part #120.

@chriseth
Copy link
Contributor

chriseth commented Oct 5, 2018

Please change commit message.

@axic axic force-pushed the solcjs-use-standardjson branch 2 times, most recently from b15a474 to 2873f92 Compare October 30, 2018 14:17
@axic axic changed the title [WIP] Use standard json internally in solcjs in every case Use standard json internally in solcjs in every case Oct 30, 2018
@axic axic force-pushed the solcjs-use-standardjson branch 2 times, most recently from d1d156b to 5cae9b9 Compare October 30, 2018 14:57
solcjs Outdated
for (var error in output['errors']) {
var message = output['errors'][error]
if (isWarning(message)) {
console.log(message)
if (message.severity !== 'warning') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

@axic axic force-pushed the solcjs-use-standardjson branch from 5cae9b9 to a872a6d Compare October 30, 2018 14:58
@axic axic merged commit 80a50f9 into master Oct 30, 2018
@axic axic deleted the solcjs-use-standardjson branch October 30, 2018 15:17
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.398% when pulling a872a6d on solcjs-use-standardjson into 41d674b on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants