Resolving Keccak-256: check if arguments are identifiers early. #11899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrkrshnn
force-pushed
the
move-check-keccak-gas
branch
from
3afe901 to
fbcdd75
Compare
hrkrshnn
force-pushed
the
move-check-keccak-gas
branch
from
fbcdd75 to
866a26b
Compare
hrkrshnn
changed the title
ekpyron
previously approved these changes
Sep 6, 2021
hrkrshnn
force-pushed
the
move-check-keccak-gas
branch
from
866a26b to
551ac81
Compare
ekpyron
previously approved these changes
Sep 6, 2021
bshastry
reviewed
Sep 6, 2021
Changelog.md
Outdated
| @@ -12,6 +12,7 @@ Compiler Features: | |||
| * SMTChecker: Add constraints to better correlate ``address(this).balance`` and ``msg.value``. | |||
| * SMTChecker: Support the ``value`` option for external function calls. | |||
| * Commandline Interface: Disallowed the ``--experimental-via-ir`` option to be used with Standard Json, Assembler and Linker modes. | |||
| * Yul Optimizer: Fix a crash in LoadResolver, when ``keccak256`` had particular arguments. | |||
There was a problem hiding this comment.
Suggested change
| * Yul Optimizer: Fix a crash in LoadResolver, when ``keccak256`` had particular arguments. | |
| * Yul Optimizer: Fix a crash in LoadResolver when ``keccak256`` has non-identifier arguments. |
There was a problem hiding this comment.
But not every non-identifier arguments? Maybe I'll change to "has particular non-identifier arguments"?
There was a problem hiding this comment.
Changed it. Writing the changelog for this was more work than the fix :)
bshastry
reviewed
Sep 6, 2021
Previously, the check on whether the optimization was useful gas wise was done before checking if the keccak256 opcode had identifier as arguments. Since the gas meter crashes when encountering certain Yul opcodes (create, dataoffset, etc.), this optimizer step crashed.
hrkrshnn
force-pushed
the
move-check-keccak-gas
branch
from
551ac81 to
2cdd3b2
Compare
ekpyron
approved these changes
Sep 6, 2021
chriseth
reviewed
Sep 6, 2021
| @@ -12,6 +12,7 @@ Compiler Features: | |||
| * SMTChecker: Add constraints to better correlate ``address(this).balance`` and ``msg.value``. | |||
| * SMTChecker: Support the ``value`` option for external function calls. | |||
| * Commandline Interface: Disallowed the ``--experimental-via-ir`` option to be used with Standard Json, Assembler and Linker modes. | |||
| * Yul Optimizer: Fix a crash in LoadResolver, when ``keccak256`` has particular non-identifier arguments. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the check on whether the optimization was useful gas wise was done before checking if
the keccak256 opcode had identifier as arguments. Since the gas meter crashes when encountering
certain Yul opcodes (create2, dataoffset, etc.), this optimizer step crashed.
Closes #11803 and #11801