-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Stop installing cvc4 on archlinux #15085
Conversation
.circleci/config.yml
Outdated
@@ -1273,7 +1273,7 @@ jobs: | |||
- run: | |||
name: Install runtime dependencies | |||
command: | | |||
pacman --noconfirm -Syu --noprogressbar --needed base-devel boost cmake z3 cvc4 git openssh tar | |||
pacman --noconfirm -Syu --noprogressbar --needed base-devel boost cmake z3 git openssh tar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually understand why z3
is installed for t_archlinux_soltest
but not for b_archlinux
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was about to comment about it. You can remove this installation step. It is already installed in b_archlinux
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, everything except z3
😄
I am also wondering about this in b_archlinux
# This can be switched off if we run out of sync with Arch.
USE_Z3: ON
Should we switch it off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, keep it for now, and also installing z3
in that step. We actually need to think about if we will reenable the tests once we update the z3 version (i.e. removing the --no-smt
flag). But for now let's keep that flag to disable the tests as well.
So just change the step to:
pacman --noconfirm -Syu --noprogressbar --needed z3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the step accordingly and the CI is still green.
c4eefd2
to
4e4fd0a
Compare
4e4fd0a
to
38f89b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if CI passes here, it proves that we're not really running anything requiring cvc4
on Arch Linux.
Before we merge this, I wanted to follow up on Rodrigo's suggestion to remove installation of dependencies in |
Ah, ok then. I wasn't going to merge it myself anyway. Just approve it and let you do it yourself in case you still wanted to change something :) Though if you're planning changes it's always safer to revert the PR back to draft.
The binary is not completely static. Z3 is actually the one thing we link dynamically and the EDIT: Actually, this job does not even build a static binary. But this does not change the situation with Z3 :) |
This change is in preparation for upgrading to cvc5. Since archlinux is not running SMT tests anyway, we can drop cvc4 from the build immediately.
38f89b9
to
d5f5742
Compare
@cameel, @r0qs, can you help me understand this? My opinion is that either |
Oh, I thought that
Yeah, I think we should just remove z3 in this case then. Since we are running the tests with |
OK, how about we continue with the conversation about Z3 in our CI channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, there's still some open questions about how to deal with this stuff going forward - but not much harm in merging this for now.
Ah, right. I assumed it was |
This change is in preparation for upgrading to cvc5. Since archlinux is not running SMT tests anyway, we can drop cvc4 from the build immediately.