Transaction tests for EIP-3860: Limit and meter initcode #1012

gumb0 · 2022-01-27T14:16:06Z

These tests check transaction validity rules change of https://eips.ethereum.org/EIPS/eip-3860
Geth implementation in ethereum/go-ethereum#23847

src/TransactionTestsFiller/ttData/DataTestInitCodeTooBigFiller.yml

jochem-brouwer · 2022-02-02T00:46:26Z

Is this one an updated version of #990?

gumb0 · 2022-02-02T13:51:20Z

Is this one an updated version of #990?

No, this is a follow-up to #990 (independent of it), here it's only transaction tests, testing specifically new rules for when transactions are invalid.

(Not that we have not updated EIP text yet to make transactions with too big initcode invalid, sorry.
But the tests here consider them invalid)

gumb0 · 2022-02-04T11:11:39Z

(Not that we have not updated EIP text yet to make transactions with too big initcode invalid, sorry. But the tests here consider them invalid)

EIP is updated now. ethereum/EIPs#4757

jochem-brouwer · 2022-02-08T16:58:06Z

Ah yes this makes sense, we are not (yet) using the TransactionTests directory in JS, we should do that rather soon especially with these transactions. Thanks for the updates! 😄

jochem-brouwer · 2022-03-02T21:08:06Z

Note: TransactionTests only supports LegacyTransactions ATM, so #990 should also include state tests or blockchain tests for situations where (1) initcode of Tx (legacy/2929/1559) is longer than max initcode and (2) sender does not pay the upfront cost of initcode analysis.

gumb0 · 2022-03-03T11:38:33Z

Note: TransactionTests only supports LegacyTransactions ATM, so #990 should also include state tests or blockchain tests for situations where (1) initcode of Tx (legacy/2929/1559) is longer than max initcode and (2) sender does not pay the upfront cost of initcode analysis.

It might be possible to add TransactionTests with different transaction types, I'll check.

But adding them as state tests is also a good idea.

jochem-brouwer · 2022-05-30T19:12:36Z

@gumb0 do these tests include tests regarding CREATE/CREATE2 with sizes maxInitCodeSize and maxInitCodeSize+1?

EDIT: nvm, these are TxTests

winsvega · 2022-11-21T08:27:31Z

src/TransactionTestsFiller/ttData/DataTestNotEnoughGasInitCodeFiller.yml

+# Creation transaction with gas limit not enough to cover initcode charge of EIP-3860
+DataTestNotEnoughGasInitCode:
+    expectException:
+        London: ""


Is there an exception on London?

winsvega · 2022-11-21T08:29:34Z

src/TransactionTestsFiller/ttData/DataTestInitCodeLimitFiller.yml

@@ -0,0 +1,15 @@
+# Creation transaction with initcode with max size allowed by EIP-3860
+DataTestInitCodeLimit:
+    expectException: {}


Is this field (expecException) required if its empty?

winsvega

Update fork Merge+3860
Put EIP3860 in the test name or a new folder ttEIP3860
London: "" in expectException can be deleted
expectException: {} can be deleted

gumb0 · 2022-11-29T15:57:17Z

src/TransactionTestsFiller/ttData/DataTestInitCodeTooBigFiller.yml

+        - Merge+3860
+    expectException:
+        Merge: ""
+        Merge+3860: "TR_InitCodeLimitExceeded"


This requires a new mapping in retesteth config:

"TR_InitCodeLimitExceeded" : "init code size limit exceeded",

gumb0 · 2022-11-29T16:04:51Z

I would leave Merge: "" and expectedException: {} for explicitness, to show that we're testing that no exception is expected.

winsvega · 2022-11-30T16:24:04Z

src/TransactionTestsFiller/ttEIP3860/DataTestNotEnoughGasInitCodeFiller.yml

+DataTestNotEnoughGasInitCode:
+    expectException:
+        Merge: ""
+        Merge+3860: "TR_IntrinsicGas"


add Merge+3860 in additionalForks section that is missing here. the test is not generated for this fork.

winsvega · 2022-11-30T16:25:00Z

src/TransactionTestsFiller/ttEIP3860/DataTestInitCodeLimitFiller.yml

@@ -0,0 +1,15 @@
+# Creation transaction with initcode with max size allowed by EIP-3860
+DataTestInitCodeLimit:
+    expectException: {}


additionalforks Merge+3860

winsvega · 2022-11-30T16:25:33Z

src/TransactionTestsFiller/ttEIP3860/DataTestEnoughGasInitCodeFiller.yml

@@ -0,0 +1,18 @@
+# Creation transaction with gas limit just enough to cover initcode charge of EIP-3860
+DataTestEnoughGasInitCode:
+    expectException: {}


additional forks Merge+3860

winsvega

by default tests are generated for each fork in progression of Forks.
but since you use fork+eip here, need to specify in the test that it should also be generated using fork+eip by defining it in additionalForks section in the test.

retesteth config change no needed.

good to have small trasaction unit tests here. very clear.

winsvega · 2022-12-01T14:49:26Z

src/TransactionTestsFiller/ttEIP3860/DataTestNotEnoughGasInitCodeFiller.yml

+    additionalForks:
+        - Merge+3860
+    expectException:
+        Merge: ""


if it is empty, then record not needed

gumb0 force-pushed the eip-3860-transactions branch from 410e09f to 00d2a74 Compare January 27, 2022 14:42

gumb0 mentioned this pull request Jan 27, 2022

core/vm: implement EIP-3860: Limit and meter initcode ethereum/go-ethereum#23847

Merged

gumb0 commented Jan 27, 2022

View reviewed changes

src/TransactionTestsFiller/ttData/DataTestInitCodeTooBigFiller.yml Outdated Show resolved Hide resolved

gumb0 mentioned this pull request Jan 27, 2022

Transaction tests: support expectations for additionalForks ethereum/retesteth#161

Closed

holgerd77 mentioned this pull request Jan 28, 2022

VM, Tx, Common: Implement EIP3860 "limit and meter initcode" ethereumjs/ethereumjs-monorepo#1619

Merged

winsvega added the in progress label Nov 7, 2022

winsvega reviewed Nov 21, 2022

View reviewed changes

winsvega requested changes Nov 22, 2022

View reviewed changes

gumb0 force-pushed the eip-3860-transactions branch from 00d2a74 to 6d42c6a Compare November 29, 2022 15:55

gumb0 commented Nov 29, 2022

View reviewed changes

gumb0 force-pushed the eip-3860-transactions branch from 6d42c6a to 0f3681d Compare November 29, 2022 16:14

gumb0 marked this pull request as ready for review November 29, 2022 16:14

gumb0 requested a review from winsvega November 29, 2022 16:14

winsvega reviewed Nov 30, 2022

View reviewed changes

winsvega requested changes Nov 30, 2022

View reviewed changes

gumb0 force-pushed the eip-3860-transactions branch from 0f3681d to e8d5364 Compare November 30, 2022 18:24

gumb0 added 3 commits November 30, 2022 19:25

Transaction tests for initcode charge of EIP-3860

28f825e

Transaction tests for initcode size limit of EIP-3860

de76006

Fill tests

e13a1f0

gumb0 force-pushed the eip-3860-transactions branch from e8d5364 to e13a1f0 Compare November 30, 2022 18:25

gumb0 requested a review from winsvega November 30, 2022 18:26

winsvega reviewed Dec 1, 2022

View reviewed changes

winsvega merged commit 24fa31a into ethereum:develop Dec 1, 2022

axic deleted the eip-3860-transactions branch December 2, 2022 00:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transaction tests for EIP-3860: Limit and meter initcode #1012

Transaction tests for EIP-3860: Limit and meter initcode #1012

gumb0 commented Jan 27, 2022 •

edited

jochem-brouwer commented Feb 2, 2022

gumb0 commented Feb 2, 2022 •

edited

gumb0 commented Feb 4, 2022

jochem-brouwer commented Feb 8, 2022

jochem-brouwer commented Mar 2, 2022

gumb0 commented Mar 3, 2022

jochem-brouwer commented May 30, 2022 •

edited

winsvega Nov 21, 2022

winsvega Nov 21, 2022

winsvega left a comment

gumb0 Nov 29, 2022

gumb0 commented Nov 29, 2022

winsvega Nov 30, 2022

winsvega Nov 30, 2022

winsvega Nov 30, 2022

winsvega left a comment

winsvega Dec 1, 2022

Transaction tests for EIP-3860: Limit and meter initcode #1012

Transaction tests for EIP-3860: Limit and meter initcode #1012

Conversation

gumb0 commented Jan 27, 2022 • edited

jochem-brouwer commented Feb 2, 2022

gumb0 commented Feb 2, 2022 • edited

gumb0 commented Feb 4, 2022

jochem-brouwer commented Feb 8, 2022

jochem-brouwer commented Mar 2, 2022

gumb0 commented Mar 3, 2022

jochem-brouwer commented May 30, 2022 • edited

winsvega Nov 21, 2022

Choose a reason for hiding this comment

winsvega Nov 21, 2022

Choose a reason for hiding this comment

winsvega left a comment

Choose a reason for hiding this comment

gumb0 Nov 29, 2022

Choose a reason for hiding this comment

gumb0 commented Nov 29, 2022

winsvega Nov 30, 2022

Choose a reason for hiding this comment

winsvega Nov 30, 2022

Choose a reason for hiding this comment

winsvega Nov 30, 2022

Choose a reason for hiding this comment

winsvega left a comment

Choose a reason for hiding this comment

winsvega Dec 1, 2022

Choose a reason for hiding this comment

gumb0 commented Jan 27, 2022 •

edited

gumb0 commented Feb 2, 2022 •

edited

jochem-brouwer commented May 30, 2022 •

edited