Skip to content

Final 1559 major updates #2066

@fselmo

Description

@fselmo

What was wrong?

  • Missing default values for maxFeePerGas and maxPriorityFeePerGas in /web3/_utils/transactions.py
  • Our unit / core tests do not test for the new EIP-1559 params maxFeePerGas and maxPriorityFeePerGas
  • Our docs still use gasPrice values in the examples / code samples rather than the new maxFeePerGas and maxPriorityFeePerGas fields

How can it be fixed?

Once eth-tester has EIP-1559 support:

  • Add agreed-upon default values for maxFeePerGas and maxPriorityFeePerGas in /web3/_utils/transactions.py
  • Update the tests that rely on eth-tester and our docs to test for / use the new params maxFeePerGas and maxPriorityFeePerGas wherever gasPrice is currently being used. We should make sure to still include some tests with the gasPrice param, wherever appropriate, to ensure our support for legacy transactions.

Note: This is dependent on eth-tester support for EIP-1559 / london hard fork

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions