-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Description
What was wrong?
- Missing default values for
maxFeePerGas
andmaxPriorityFeePerGas
in/web3/_utils/transactions.py
- Our unit / core tests do not test for the new EIP-1559 params
maxFeePerGas
andmaxPriorityFeePerGas
- Our docs still use
gasPrice
values in the examples / code samples rather than the newmaxFeePerGas
andmaxPriorityFeePerGas
fields
How can it be fixed?
Once eth-tester has EIP-1559 support:
- Add agreed-upon default values for
maxFeePerGas
andmaxPriorityFeePerGas
in/web3/_utils/transactions.py
- Update the tests that rely on eth-tester and our docs to test for / use the new params
maxFeePerGas
andmaxPriorityFeePerGas
wherevergasPrice
is currently being used. We should make sure to still include some tests with thegasPrice
param, wherever appropriate, to ensure our support for legacy transactions.
Note: This is dependent on eth-tester support for EIP-1559 / london hard fork
Metadata
Metadata
Assignees
Labels
No labels