Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snakecase address helpers #2708

Merged
merged 4 commits into from Nov 4, 2022

Conversation

linda-le1
Copy link
Contributor

What was wrong?

Inherited javascript syntax. This PR does not include a deprecation step, intended for v6.
Related to Issue #2598

How was it fixed?

Changed toAddress to to_address, isChecksumAddress to is_checksum_address, and toChecksumAddress to to_checksum_address.

Todo:

Cute Animal Picture

Screen Shot 2022-11-02 at 11 36 37 PM

@linda-le1 linda-le1 marked this pull request as ready for review November 3, 2022 05:56
@linda-le1
Copy link
Contributor Author

@kclowes @pacrob @fselmo tagging for PR review - thank you!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants