Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd test to verify client consistency with None topic args #985
Conversation
dylanjw
force-pushed the
dylanjw:filter-param-check
branch
from
c725bc1
to
d85252d
Aug 1, 2018
dylanjw
referenced this pull request
Aug 1, 2018
Merged
Fix topic_list parameter implementation (matching and validation) to align with JSON-RPC spec #118
dylanjw
force-pushed the
dylanjw:filter-param-check
branch
5 times, most recently
from
09e57b2
to
14dd2ec
Aug 1, 2018
tests/integration/parity/common.py
Outdated
| @@ -97,6 +97,10 @@ def test_eth_getTransactionReceipt_unmined(self, web3, unlocked_account): | ||
| assert receipt is not None | ||
| assert receipt['blockHash'] is None | ||
| def test_eth_getLogs_with_logs_none_topic_args(self, web3): | ||
| with pytest.raises(AssertionError): |
This comment has been minimized.
This comment has been minimized.
carver
Aug 3, 2018
Collaborator
In all the other places I can think of, we do @pytest.mark.xfail instead of this approach. Nothing wrong with this that I can think of, it's just nice to have a little more stylistic consistency.
dylanjw
force-pushed the
dylanjw:filter-param-check
branch
from
14dd2ec
to
91b64f7
Aug 5, 2018
dylanjw
force-pushed the
dylanjw:filter-param-check
branch
from
91b64f7
to
79b2970
Aug 6, 2018
dylanjw
merged commit 13af169
into
ethereum:master
Aug 6, 2018
28 checks passed
ci/circleci: doctest
Your tests passed on CircleCI!
Details
ci/circleci: lint
Your tests passed on CircleCI!
Details
ci/circleci: py35-core
Your tests passed on CircleCI!
Details
ci/circleci: py35-ens
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-ethtester-pyethereum
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-ethtester-pyevm
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-goethereum-http-1.7.2
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-goethereum-http-1.8.1
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-goethereum-ipc-1.7.2
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-goethereum-ipc-1.8.1
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-goethereum-ws-1.7.2
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-goethereum-ws-1.8.1
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-parity-http
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-parity-ipc
Your tests passed on CircleCI!
Details
ci/circleci: py35-integration-parity-ws
Your tests passed on CircleCI!
Details
ci/circleci: py36-core
Your tests passed on CircleCI!
Details
ci/circleci: py36-ens
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-ethtester-pyethereum
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-ethtester-pyevm
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.7.2
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.8.1
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.7.2
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.8.1
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.7.2
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.8.1
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-http
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ipc
Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ws
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dylanjw commentedAug 1, 2018
What was wrong?
Want to verify client handling of None topic parameters yields consistent match results.
How was it fixed?
Extended the getLogs test to try retrieving log matches using None values for topics.
Cute Animal Picture