Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to verify client consistency with None topic args #985

Merged
merged 2 commits into from Aug 6, 2018

Conversation

dylanjw
Copy link
Contributor

@dylanjw dylanjw commented Aug 1, 2018

What was wrong?

Want to verify client handling of None topic parameters yields consistent match results.

How was it fixed?

Extended the getLogs test to try retrieving log matches using None values for topics.

Cute Animal Picture

image

@dylanjw dylanjw force-pushed the filter-param-check branch 5 times, most recently from 09e57b2 to 14dd2ec Compare August 2, 2018 21:10
@@ -97,6 +97,10 @@ def test_eth_getTransactionReceipt_unmined(self, web3, unlocked_account):
assert receipt is not None
assert receipt['blockHash'] is None

def test_eth_getLogs_with_logs_none_topic_args(self, web3):
with pytest.raises(AssertionError):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all the other places I can think of, we do @pytest.mark.xfail instead of this approach. Nothing wrong with this that I can think of, it's just nice to have a little more stylistic consistency.

@dylanjw dylanjw merged commit 13af169 into ethereum:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants