This repository was archived by the owner on Dec 10, 2020. It is now read-only.
Remove unused ms package from deps #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
- Coverage 74.53% 74.40% -0.14%
==========================================
Files 44 44
Lines 1500 1500
Branches 196 195 -1
==========================================
- Hits 1118 1116 -2
- Misses 322 323 +1
- Partials 60 61 +1
Continue to review full report at Codecov.
|
holgerd77
approved these changes
Nov 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like ms package isn't in use: I couldn't find it in
lib/,test/orbin/directories. So I've removed it. All tests pass successfully.This PR is part of #149 issue.