-
Notifications
You must be signed in to change notification settings - Fork 831
github actions: cache deps, run nightly test #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7c0acb
to
4900853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything in the vm-test.yml
looks good!
@ryanio would you please add cache to the Coverage and Lint jobs as well?
e0983fa
to
6d180ab
Compare
…running actions on pull_request
6d180ab
to
72a937c
Compare
oops accidentally committed some residual test files for the PR labeler so that's why the labels got added.
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ryan, great work! Also had a short look, change requests from @evertonfraga have been addressed so I think this should be ready for merge.
I think we might now also be ready here to also remove the CircleCI support along one of the next PRs? Will move the requirement checks from Circle to Actions after this post.
Will dismiss, changes addressed.
@ryanio that was me! I created the labels manually, so we have one more item crossed for the migration. |
The nightly test successfully ran tonight. 🎉 @ryanio |
Nice |
Adds caching of
node_modules
for faster gh action runs.See how a cache hit looks here.
Note: we don't have a
package-lock.json
file in this repository so I am hashingpackage.json
as the cache key instead (also what happens in current.circleci
). @alcuadrado likes not having apackage-lock.json
"as it forces us and the CI to experience the libraries as users would."@evertonfraga suggested we run a nightly job without caching to catch any potential issues that may happen when an in-range dependency update breaks the build or tests, so I added
vm-nightly-test.yml
that runs without any caching.Also accidentally missed running gh actions on
pull_request
so this PR includes that.