Skip to content

Conversation

axic
Copy link
Member

@axic axic commented Jan 9, 2019

No description provided.

@axic axic requested a review from hugo-dc January 9, 2019 03:13
Copy link
Contributor

@hugo-dc hugo-dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to update the compiled js file too?

@axic
Copy link
Member Author

axic commented Jan 9, 2019

@hugo-dc it should produce the exact same output, if you can check that would be great.

@hugo-dc
Copy link
Contributor

hugo-dc commented Jan 9, 2019

@axic I already tried to compile to js, but had some issues with my emscripten installation and had to install it again, then I compiled to js correctly but it is giving a different output, it gives a different output even if I run in in the master branch. Maybe the emscripten version I'm using is different than the one used previously.

@axic
Copy link
Member Author

axic commented Jan 10, 2019

Maybe the emscripten version I'm using is different than the one used previously.

Likely. As long as this compiles it should be fine. Tested it also locally here. WIll merge.

@axic axic merged commit 3f2ee23 into master Jan 10, 2019
@axic axic deleted the fmt branch January 10, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants