Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docusaurus config #1

Merged
merged 8 commits into from
Feb 4, 2021
Merged

fix: docusaurus config #1

merged 8 commits into from
Feb 4, 2021

Conversation

vojtechsimetka
Copy link
Contributor

Fixes some local warning, adds correct repo URLs and fixes typerror in lunar search when run locally (see praveenn77/docusaurus-lunr-search#33 )

@significance
Copy link
Member

@vojtechsimetka looks good as far as i can see but not building - happy to approve or let me know how best to check otherwise

@vojtechsimetka
Copy link
Contributor Author

@significance that is because the fix for that was in a different branch. Now I've merged it and it works as you can see here https://github.com/ethersphere/bee-js.github.io/pull/1/checks?check_run_id=1821256237

Copy link
Member

@significance significance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small change as per comment as far as i can see, otherwise looks good!

Copy link
Member

@significance significance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 😀

@vojtechsimetka vojtechsimetka merged commit 822f6fe into master Feb 4, 2021
@vojtechsimetka vojtechsimetka deleted the fix/config branch February 4, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants