Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

[DevOps] Ensure MSSQL deps can be installed in production #635

Closed
seanpreston opened this issue Jun 10, 2022 · 0 comments · Fixed by #664
Closed

[DevOps] Ensure MSSQL deps can be installed in production #635

seanpreston opened this issue Jun 10, 2022 · 0 comments · Fixed by #664
Assignees
@pattisdr
Labels
bug Something isn't working

Comments

@seanpreston
Copy link
Contributor

seanpreston commented Jun 10, 2022 •
edited by mfbrown
Loading

The Fidesops Dockerfile currently expects an $MSSQL_REQUIRED var to ensure it downloads and installs the MSSQL dependencies from mssql-requirements.txt.

To be sure anyone using the Fidesops Dockerfile has MSSQL connection capabilities installed by default, we should default this var to true, and manually specify it as False everywhere that it is not required.
@seanpreston seanpreston added the bug Something isn't working label Jun 10, 2022
@pattisdr pattisdr self-assigned this Jun 15, 2022
@pattisdr pattisdr mentioned this issue Jun 16, 2022
Merged
10 tasks
seanpreston pushed a commit that referenced this issue Jun 17, 2022
@pattisdr
Install MSSQL Dependencies by Default [#635] (#664)
acb3126 
* Have MSSQL dependencies be installed by default in the dockerfile by flipping the variable's meaning to SKIP_MSSQL_INSTALLATION.

* Update changelog.
sanders41 pushed a commit that referenced this issue Sep 22, 2022
@pattisdr
Install MSSQL Dependencies by Default [#635] (#664)
62c3060 
* Have MSSQL dependencies be installed by default in the dockerfile by flipping the variable's meaning to SKIP_MSSQL_INSTALLATION.

* Update changelog.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pattisdr pattisdr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install MSSQL Dependencies by Default [#635] ethyca/fidesops
2 participants
@seanpreston @pattisdr