This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Install MSSQL Dependencies by Default [#635] #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flipping the variable's meaning to SKIP_MSSQL_INSTALLATION.
seanpreston
suggested changes
Jun 16, 2022
| @@ -45,7 +45,7 @@ RUN pip install -U pip \ | |||
| && pip install snowflake-connector-python --no-use-pep517 \ | |||
| && pip install -r requirements.txt -r dev-requirements.txt | |||
|
|
|||
| RUN if [ "$MSSQL_REQUIRED" = "true" ] ; then pip install -U pip -r mssql-requirements.txt ; fi | |||
| RUN if [ "$SKIP_MSSQL_INSTALLATION" != "true" ] ; then pip install -U pip -r mssql-requirements.txt ; fi | |||
There was a problem hiding this comment.
We need to change these conditionals to false
There was a problem hiding this comment.
I don't understand, I am saying if $SKIP_MSSQL_INSTALLATION is not equal to true, here, so if nothing is passed in, MSSQL is installed by default. It seemed cleaner to do it this way so by default no variable needs to be set at all.
There was a problem hiding this comment.
My apologies, I missed the !
seanpreston
approved these changes
Jun 16, 2022
# Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Have MSSQL dependencies be installed by default.
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #635