Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in Findglog.cmake #30

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix warnings in Findglog.cmake #30

merged 1 commit into from
Oct 8, 2024

Conversation

4c3y
Copy link
Member

@4c3y 4c3y commented Sep 24, 2024

Fix CMake warnings when using recent versions of cmake on ubuntu 20.04 caused by calling find_package_handle_standard_args() in Findglog.cmake for glog and PkgConfig

CMake Warning (dev) at /opt/clion-2023.1.4/bin/cmake/linux/x64/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (glog).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.

Copy link

@mikeallenspach mikeallenspach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4c3y 4c3y merged commit 03c55f6 into master Oct 8, 2024
21 checks passed
@4c3y 4c3y deleted the fix/cmake_warnings branch October 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants