-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bad observations #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very general comments, and a few smaller ones I just noticed. If you do some of them I'm happy to have a second look
algorithms/landmark-triangulation/include/landmark-triangulation/landmark-triangulation.h
Outdated
Show resolved
Hide resolved
algorithms/vi-map-helpers/src/vi-map-landmark-quality-evaluation.cc
Outdated
Show resolved
Hide resolved
algorithms/vi-map-helpers/src/vi-map-landmark-quality-evaluation.cc
Outdated
Show resolved
Hide resolved
algorithms/vi-map-helpers/src/vi-map-landmark-quality-evaluation.cc
Outdated
Show resolved
Hide resolved
algorithms/vi-map-helpers/src/vi-map-landmark-quality-evaluation.cc
Outdated
Show resolved
Hide resolved
algorithms/vi-map-helpers/src/vi-map-landmark-quality-evaluation.cc
Outdated
Show resolved
Hide resolved
algorithms/vi-map-helpers/src/vi-map-landmark-quality-evaluation.cc
Outdated
Show resolved
Hide resolved
@patripfr so I should have solved now all the issues we talked about (parallelizing removal of tracks and handling -1 track ids). If you could check my code and I think there's a few last points:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor changes and otherwise LGTM. I'll do these myself and then I think it's in a good state to merge
algorithms/landmark-triangulation/include/landmark-triangulation/landmark-triangulation.h
Outdated
Show resolved
Hide resolved
Test PASSed. |
Test FAILed. |
Test PASSed. |
Test PASSed. |
Added a new command
remove_invalid_observations
->rio
, that solves the issues brought up by check_map_consistency, namely landmarks that due to loop closure are observed multiple times from the same frame (which is impossible). This command splits away the worse tracks and reinitializes them again as new landmarks.