Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list_datasets function #149

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Conversation

Alexander76Kuznetsov
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #145

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (internal_datasets@78a0de1). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             internal_datasets     #149   +/-   ##
====================================================
  Coverage                     ?   88.93%           
====================================================
  Files                        ?      205           
  Lines                        ?    13026           
  Branches                     ?        0           
====================================================
  Hits                         ?    11585           
  Misses                       ?     1441           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 16, 2023

🚀 Deployed on https://deploy-preview-149--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 16, 2023 13:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 16, 2023 14:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 16, 2023 16:08 Inactive
@@ -332,3 +333,8 @@ def test_df_exog_statistics(
assert part.df_exog.shape == expected_df_exog_shapes[i]
for i, part in enumerate(ts_parts):
assert (part.df_exog.index.min(), part.df_exog.index.max()) == expected_df_exog_dates[i]


def test_list_datasets():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should check the specific value here (currently 22)

@github-actions github-actions bot temporarily deployed to pull request November 17, 2023 09:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 17, 2023 10:33 Inactive
@Alexander76Kuznetsov Alexander76Kuznetsov merged commit 4ad6465 into internal_datasets Nov 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants