Allow to change device, batch_size and num_workers of embedding models
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-396--etna-docs.netlify.app |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
- Coverage 88.88% 9.61% -79.27%
==========================================
Files 224 226 +2
Lines 15381 15572 +191
==========================================
- Hits 13672 1498 -12174
- Misses 1709 14074 +12365 ☔ View full report in Codecov by Sentry. |
d-a-bunin
reviewed
Jun 18, 2024
d-a-bunin
reviewed
Jun 18, 2024
d-a-bunin
reviewed
Jun 19, 2024
| @@ -239,7 +258,7 @@ def save(self, path: pathlib.Path): | |||
|
|
|||
| @classmethod | |||
| def load(cls, path: pathlib.Path) -> "TS2VecEmbeddingModel": | |||
| """Load an object. | |||
| """Load an object. Model's weights are transferred to cpu during loading. | |||
There was a problem hiding this comment.
This clarification about CPU should go in extended summary on next line after empty line.
d-a-bunin
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #394