Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add M3 to internal_datasets #91

Merged
merged 8 commits into from
Oct 2, 2023
Merged

add M3 to internal_datasets #91

merged 8 commits into from
Oct 2, 2023

Conversation

egoriyaa
Copy link
Collaborator

@egoriyaa egoriyaa commented Sep 26, 2023 •
edited
Loading

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #84

@egoriyaa egoriyaa self-assigned this Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (internal_datasets@176e200). Click here to learn what that means.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##             internal_datasets      #91   +/-   ##
====================================================
  Coverage                     ?   89.14%           
====================================================
  Files                        ?      205           
  Lines                        ?    12880           
  Branches                     ?        0           
====================================================
  Hits                         ?    11482           
  Misses                       ?     1398           
  Partials                     ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-91--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 26, 2023 09:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 27, 2023 13:41 Inactive
@d-a-bunin d-a-bunin self-requested a review September 27, 2023 15:49
d-a-bunin
d-a-bunin requested changes Sep 28, 2023
View reviewed changes
etna/datasets/internal_datasets.py Outdated Show resolved Hide resolved
etna/datasets/internal_datasets.py Outdated Show resolved Hide resolved
etna/datasets/internal_datasets.py Show resolved Hide resolved
tests/test_datasets/test_internal_datasets.py Outdated Show resolved Hide resolved
tests/test_datasets/test_internal_datasets.py Outdated Show resolved Hide resolved
tests/test_datasets/test_internal_datasets.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request September 29, 2023 10:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 29, 2023 10:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 2, 2023 08:08 Inactive
d-a-bunin
d-a-bunin requested changes Oct 2, 2023
View reviewed changes
tests/test_datasets/test_internal_datasets.py Outdated Show resolved Hide resolved
etna/datasets/internal_datasets.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request October 2, 2023 09:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 2, 2023 09:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 2, 2023 09:59 Inactive
@egoriyaa egoriyaa merged commit a1eeab6 into internal_datasets Oct 2, 2023
15 checks passed
@egoriyaa egoriyaa deleted the issue-84 branch October 2, 2023 11:48
@egoriyaa egoriyaa mentioned this pull request Oct 2, 2023
Closed
ostreech1997 pushed a commit that referenced this pull request Dec 4, 2023
@egoriyaa @ostreech1997
add M3 to internal_datasets (#91)
e7285b6 
* add M3 to internal_datasets

* add df_exog to m3 dataset

* minor fixes, add exog dir

* delete ssl

* minor fixs

* fix tests

* fix docs

* fix docs

---------

Co-authored-by: Egor Baturin <egoriyaa@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostreech1997 ostreech1997 ostreech1997 left review comments

@d-a-bunin d-a-bunin d-a-bunin approved these changes

Assignees

@egoriyaa egoriyaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egoriyaa @ostreech1997 @d-a-bunin