Update correct line numbers in LocationSpec #1152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @som-snytt. I adjusted in the fix in 947e823 so that the spec passes both specs2 current CI and the community build for the next scala version. |
|
One thing I don't know though is how the community build selects a proper specs2 version for its build. |
|
Clever! Thanks, and of course I have no idea if/when the PR might be accepted on the Scala 3 side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test breaks with scala/scala3#17428
I'm not sure what the protocol is for a project participating in the community build, where this behavior change was noticed.
Parking this here for reference.