Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/ets-labs/python-dependency-injector/blob/master/src/dependency_injector/providers.pyx#L1389-L1400
maybe here we should deep copy the original value then modify it ?
or is this (not support reset override) expected behavior?
def test_configuration_set(): from dependency_injector import providers config = providers.Configuration( name="config", default={"a": {"b": {"c": 1, "d": 2}}} ) assert config.a.b.c() == 1 with config.set("a.b.c", "xxx"): assert config.a.b.c() == "xxx" assert config.a.b.c() == 1 # will fail here, AssertionError: assert 'xxx' == 1 with config.a.b.c.override("yyy"): assert config.a.b.c() == "yyy" assert config.a.b.c() == 1 # will fail here, AssertionError: assert 'yyy' == 1
The text was updated successfully, but these errors were encountered:
Fix issue #319 resulting in configuration.reset_override() not workin…
18ef566
…g properly
Hi @lust4life , thanks for reporting the issue and suggesting a fix. I've added provided test to the test suite, implemented a fix and released new version 4.3.4.
4.3.4
Sorry, something went wrong.
That's really nice! ❤️
rmk135
No branches or pull requests
https://github.com/ets-labs/python-dependency-injector/blob/master/src/dependency_injector/providers.pyx#L1389-L1400
maybe here we should deep copy the original value then modify it ?
or is this (not support reset override) expected behavior?
The text was updated successfully, but these errors were encountered: