Skip to content

Conversation

xotonic
Copy link
Contributor

@xotonic xotonic commented Jun 7, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jun 7, 2019

Coverage Status

Coverage remained the same at 93.54% when pulling ffb3840 on xotonic:patch-1 into 3ced0ed on ets-labs:develop.


Userful links
Useful links
~~~~~~~~~~~~~

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you, please, also align this line with previous one? Number of ~ should match the length of the header.

@rmogylatov-cisco
Copy link

Hi @xotonic ,

Thanks a lot for the fix.

Can I, please, ask you to take a look on little comment above and also change base branch to "develop"?

Thanks,
Roman

@xotonic xotonic changed the base branch from master to develop June 7, 2019 13:46
@rmk135 rmk135 self-requested a review June 7, 2019 13:54
@rmk135 rmk135 self-assigned this Jun 7, 2019
@rmk135
Copy link
Member

rmk135 commented Jun 7, 2019

Awesome! Thank you!

@rmk135 rmk135 merged commit bcbdc7d into ets-labs:develop Jun 7, 2019
@rmk135
Copy link
Member

rmk135 commented Jun 7, 2019

@xotonic ,

Release 3.14.7 with a fix has been productized:

I've added you to the list of contributors - https://github.com/ets-labs/python-dependency-injector/blob/master/CONTRIBUTORS.rst

Thanks a lot for your contribution - it's very appreciated!

Regards,
Roman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants