Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References with Author Year style #55

Closed
d70-t opened this issue May 2, 2021 · 6 comments
Closed

References with Author Year style #55

d70-t opened this issue May 2, 2021 · 6 comments
Labels
good first issue Good for newcomers

Comments

@d70-t
Copy link
Collaborator

d70-t commented May 2, 2021

References should be in Author Year style in stead of initial letter. However we are not yet sure how to set this up properly. See #54 for the progress so far.

@observingClouds
Copy link
Collaborator

I follow up on this issue because not only does the author year look more pleasing, but it makes more sense when differentiating between text-citations and parentheses-citations. I think the readability of the pages would benefit from this distinction.

#75 applies this distinction and also changes to the author year format.

What is your opinion? This requires sphinxcontrib.bibtex>=2.2.0 but shouldn't be any longer of concern as it was in #54 and in particular in this comment. Version 2.2.0 is over a year old and should be widely supported by now.

@d70-t
Copy link
Collaborator Author

d70-t commented Mar 28, 2022

Thanks for pushing this forward!

As far as I can see, the book builds cleanly now, however as this commit introduced sphinxcontrib.bibtex>=2.2.0 to jupyterbook, we might have to require jupyterbook>=0.12.2 for this to work nicely everywhere.

@observingClouds
Copy link
Collaborator

Thanks for the positive feedback!

I cannot follow from the your @d70-t referenced commit that we need to bump up the jupyterbook version. The referenced commit is already present in version 0.11.0a1. Therefore the current requirement of jupyter-book>0.11.0 should be fine, right?

@d70-t
Copy link
Collaborator Author

d70-t commented Mar 28, 2022

Indeed... it seems I'm not skillful enough in using git blame properly...

@observingClouds
Copy link
Collaborator

Great, then #75 should now close this issue 😄

@d70-t
Copy link
Collaborator Author

d70-t commented Mar 28, 2022

#75 is now merged 🎉

@d70-t d70-t closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants