Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author_year citation style #75

Merged
merged 10 commits into from
Mar 28, 2022
Merged

Author_year citation style #75

merged 10 commits into from
Mar 28, 2022

Conversation

observingClouds
Copy link
Collaborator

#55

Copy link
Collaborator

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this long-awaited addition 👍. It looks quite good so far!

As #74 is now merged, there should probably be another merge from master, fixing the newly added citations. Afterwards, this PR would be good to go.

As a tiny visual improvement, I'm wondering if we should try to make the brackets round, using a method like the one described here. Due to jupyterbook, this might also require a local extension as described here. As this is quite a bit of work for "only" a little visual improvement, I'd also be fine to make this a separate issue and merge this PR in its current form.

how_to_eurec4a/intro.md Outdated Show resolved Hide resolved
@d70-t
Copy link
Collaborator

d70-t commented Mar 28, 2022

As mentioned in #55, this PR should probably update to jupyter-book>=0.12.2 in requirements.txt.

@observingClouds
Copy link
Collaborator Author

The updated pull-request includes now the visual improvements as well:

  • round brackets

  • improved references by using the APA style.
    Before:
    image

    After:
    image

@observingClouds
Copy link
Collaborator Author

Ah, one moment. It seems like the APA references did not work properly in the test. I must have forgotten to push something.

@d70-t
Copy link
Collaborator

d70-t commented Mar 28, 2022

This would be an awesome solution! However, in the current build, I only see the following...
APAa

@observingClouds
Copy link
Collaborator Author

Yes, this is what I'm currently working on. On my local machine it worked and the versions of the obvious packages agree between my local setup and the CI. Let's see if the current build will work.

@observingClouds
Copy link
Collaborator Author

Now it should work @d70-t. The build looks promising. It just timed out for the cloud mask page.

@observingClouds observingClouds marked this pull request as ready for review March 28, 2022 15:54
Copy link
Collaborator

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for ths PR, this citation style is much better than what we've had before!

@d70-t
Copy link
Collaborator

d70-t commented Mar 28, 2022

I really would like to know what's the issue behind the cloudmasks article... But I've no idea yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants