Specify driver name in device constructors #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WasabiFan
requested changes
Sep 25, 2016
| @@ -893,7 +893,7 @@ class FirgelliL1250Motor(Motor): | |||
|
|
|||
| def __init__(self, address=None, name_pattern=SYSTEM_DEVICE_NAME_CONVENTION, name_exact=False, **kwargs): | |||
|
|
|||
| super(FirgelliL1250Motor, self).__init__(address, name_pattern, name_exact, **kwargs) | |||
| super(FirgelliL1250Motor, self).__init__(address, name_pattern, name_exact, driver_name=['fi-l12-ev3-50'], **kwargs) | |||
There was a problem hiding this comment.
This should be the new driver name (the company is now called Actuonix, or something like that); we might need to update the spec for that. The class name needs to be renamed as well.
ddemidov
added a commit
to ev3dev/ev3dev-lang
that referenced
this pull request
Sep 25, 2016
See discussion in ev3dev/ev3dev-lang-python#216
ddemidov
added a commit
to ev3dev/ev3dev-lang
that referenced
this pull request
Sep 25, 2016
WasabiFan
approved these changes
Sep 25, 2016
|
When you merge, please choose the "squash" option and add a note to the message about renaming Firgelli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215