Get rid of size parameter in FileCache.read #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've split the commit into smaller parts. You may want to pick the first three even if you decide to omit c9b6d35 for now. |
|
Have you tested the code on the target yet :-) |
|
I've tested it on fake target. Why, do you get any failures? |
|
Ok, I've just tested it on EV3 and both attribute IO and keyboard work. |
|
Thanks! |
rhempel
added a commit
that referenced
this pull request
Oct 30, 2015
Get rid of size parameter in FileCache.read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in 91bfa71.