keep track of the arguments passed to the action #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danReynolds
force-pushed
the
feature/passArgsInAsyncAction
branch
from
5ef2a1a to
e050ac7
Compare
|
Coveralls man take it easy. |
evanhobbs
approved these changes
Nov 8, 2017
| * // cause the makeRequest promise to be rejected will also get caught here as `resp` | ||
| * // and cause a failed request action. | ||
| * meta = {}, | ||
| * meta: {}, |
src/async-action.js
Outdated
| return { | ||
| type: namespace, | ||
| ...action, | ||
| args, |
There was a problem hiding this comment.
Could we call this actionCreatorArgs to be a little more explicit?
src/middleware.js
Outdated
| // additional meta that will be passed to the action if any - must be an object | ||
| meta = {}, | ||
| // arguments passed to the action when it was invoked. | ||
| args = {}, |
danReynolds
force-pushed
the
feature/passArgsInAsyncAction
branch
from
67d6ac8 to
b341232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the start, success and fail actions for a an async action to keep track of the arguments the action was invoked with.