Added 'groups add/del' functionality and added a --reinstall option. resolves #7 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countsudoku
changed the title
countsudoku
changed the title
countsudoku
changed the title
Conflicts: bin/dots contrib/bash_completion The tabs were replaced in both branches. Now I merge both brnaches again and solved all Conflicts
|
I've merged the recent changes from other pull requests and some other changes into my branch. So that this is mergable again. |
|
@evanpurkhiser is there any chance, that this gets merged? |
|
Hi @countsudoku I'm actually working on a golang rewrite of dots on the go-rewrite branch. It's still somewhat early, but I do plan to support the reinstall feature. However, I likely won't support adding or removing groups, since order is important when specifying a group list. See GH-20 for my upcoming ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If added two new parameter to the groups command. add, which adds groups to the current used groups and del, which removes groups from the current used groups.
So you don't have to use groups set with every current groups and the new group. Now you can use groups add to add one or more groups or group del to remove one or more groups from/to the existing groups.
I've also implemented the --reinstall option with abrevation -r. This resolves #7