Added option to inject PoolClient to PongoClient as the first step for transaction handling #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to that pongoClient.close can close connection pools without needing to call endAllPools. PongoClient will track opened dbClients and close them all.
That will enable running transactions and sharing connection with Emmett projections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That will enable running transactions and sharing connections with Emmett projections.
Fixed connection pool management to correctly handle database names. This is needed as PostgreSQL connection pool is resolved per database. Thanks to that,
pongoClient.closecan close connection pools without needing to callendAllPools.endAllPoollsstill applies if you want to brute force close all active connection pools.PongoClient will track opened dbClients and close them all.