Changed _id type to TEXT #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
added
enhancement
oskardudycz
force-pushed
the
changed_primary_key_to_text
branch
2 times, most recently
from
4a9ed43 to
a543c61
Compare
Changed _id type to Text. In PostgreSQL this should be almost equally the same indexable. Of course it'll take a bit more storage, but let's live with that for now. We can in the future allow as Marten does to use different definition of collection table. Changing from uuid to text will allow more sophisticated key strategies. Most importantly it'll reuse the stream id as document id for Emmett projections. Besides that added columns for future concepts: - _version - for optimistic concurrency handling, - _partition - for built-in PostgreSQL partitioning, - _created, _modified - for timestamp metadata, - metadata - for technical additional data, - _archived - for soft deletion and also partitioning
oskardudycz
force-pushed
the
changed_primary_key_to_text
branch
from
a543c61 to
1214866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed _id type to Text. In PostgreSQL, this should be almost equally the same indexable. Of course, it'll take a bit more storage, but let's live with that for now.
We can, in the future, allow, as Marten does, to use different definitions of collection tables.
Changing from
uuidto text will allow more sophisticated key strategies.Most importantly, it'll reuse the stream ID as a document ID for Emmett projections.
Besides that, I added columns for future concepts:
_version- for optimistic concurrency handling,_partition- for built-in PostgreSQL partitioning,_created,_modified- for timestamp metadata,metadata- for technical additional data,_archived- for soft deletion and also partitioning