Fix CommandHandler type definition for handleOptions
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oskardudycz thank you for all you do |
Yup, that was my copy/paste mistake; I apologise for that and thank you for fixing it. I'm pulling that in and making the new release.
I thank you; you've made my day with this comment ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code specified that
handleOptionswas of the typeHandleOptions<StreamVersion, EventStore<...>>using the emmettEventStoreinstead of the genericStore. This prevented TS from allowing you to pass any custom options from a custom implementation of event store to the command handler.This fixes what I assume was a typo and allows you to have custom options again.