Fix issue with empty array for IN-clause #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an IN-clause is created with an empty array PostgreSQL will blow up with an SQL-Error as the resulting SQL would be ` x IN()` which is not allowed. This commit works around that by returning a query-part that always returns false as querying for something that is not part of something else will always return false.
heiglandreas
force-pushed
the
handleEmptyArrayWithInClause
branch
from
0d3d935
to
8344693
Compare
codeliner
approved these changes
Apr 30, 2020
|
Thx @heiglandreas . I'll publish a bugfix release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an IN-clause is created with an empty array PostgreSQL will blow up
with an SQL-Error as the resulting SQL would be
x IN()which is notallowed.
This commit works around that by returning a query-part that always returns
false as querying for something that is not part of something else will always return false.