Extract order by processing logic to a separate class #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zluiten
force-pushed
the
feature/extract-orderby-processor
branch
2 times, most recently
from
a6e7ef2 to
ca8bfa6
Compare
codeliner
approved these changes
Apr 4, 2022
|
We're fans of explicit code. Even thought both VOs look the same they have different meaning (especially as a type in the respective processor interface). Therefore, I think we should not introduce a |
|
I can follow that reasoning. I prefer explicity typing myself as well. |
zluiten
force-pushed
the
feature/extract-orderby-processor
branch
from
ca8bfa6 to
909c5d4
Compare
|
I've added 2 unit tests |
codeliner
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
The OrderByClause is basically a duplicate of the FilterClause value object. Which pops up the question: should both VO's be replaced by a new more generic "SqlClause"...