Fixed Issue #65: Markers attach to an XMachine or an XContext #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attach the markers to the XContext's name if no child element found (see Issue eventB-Soton#65)
Attach the markers to the XMachine's name if no child element found (see Issue eventB-Soton#65)
cfsnook
reviewed
Feb 2, 2021
| EStructuralFeature feature = this.getFeature(obj, attributeType); | ||
| EObject elem = obj; | ||
| if ((feature == null)) { | ||
| elem = this.getMachine(obj); |
There was a problem hiding this comment.
could you use
((EventBObject)obj).getContaining(MachinePackage.Literals.MACHINE);
| EStructuralFeature feature = this.getFeature(obj, attributeType); | ||
| EObject elem = obj; | ||
| if ((feature == null)) { | ||
| elem = this.getContext(obj); |
There was a problem hiding this comment.
could you use
((EventBObject)obj).getContaining(ContextPackage.Literals.CONTEXT);
| var feature = getFeature(obj, attributeType) | ||
| var elem = obj | ||
| if (feature === null) { | ||
| elem = getContext(obj) |
There was a problem hiding this comment.
could you use
((EventBObject)obj).getContaining(ContextPackage.Literals.CONTEXT);
There was a problem hiding this comment.
Thanks @cfsnook. I reimplemented the utility methods to use EventBObject.getContaining() method.
Use EventBObject.getContaining() to get the containing Machine or Context of the element corresponding to the RodinMarker.
cfsnook
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markers are now attached to the name of the XMachine or XContext if there are no element/feature found corresponding to the original issue